Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change MQTT connection to behave more like MySkoda app #303

Merged
merged 1 commit into from
Dec 29, 2024
Merged

Change MQTT connection to behave more like MySkoda app #303

merged 1 commit into from
Dec 29, 2024
+14 −7

Conversation

prvakt
Copy link
Collaborator

@prvakt prvakt commented Dec 28, 2024

couple of changes to mimic MySkoda app behaviour

  • MQTT_KEEPALIVE = 60
  • clean_session = true
  • generate UUID only once and keep same as long as the application is running
  • first 10 mqtt reconnects without backoff. MySkoda app is connecting to MQTT usually 2-5 times until its succeeded

@WebSpider WebSpider added the bug Something isn't working label Dec 29, 2024
@WebSpider WebSpider changed the title improve mqtt connection Change MQTT connection to be have more like MySkoda app Dec 29, 2024
@WebSpider WebSpider changed the title Change MQTT connection to be have more like MySkoda app Change MQTT connection to behave more like MySkoda app Dec 29, 2024
WebSpider
WebSpider approved these changes Dec 29, 2024
View reviewed changes
Copy link
Contributor

@WebSpider WebSpider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@prvakt prvakt merged commit 6bfdbef into skodaconnect:main Dec 29, 2024
1 of 2 checks passed
@prvakt prvakt deleted the improve-mqtt branch December 29, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WebSpider WebSpider WebSpider approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prvakt @WebSpider