Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add fixture for CitigoE iV 2020 style #291

Merged
merged 3 commits into from
Dec 19, 2024
Merged

add fixture for CitigoE iV 2020 style #291

merged 3 commits into from
Dec 19, 2024

Conversation

bjacquot
Copy link
Contributor

@bjacquot bjacquot commented Dec 18, 2024 •
edited
Loading

maybe it could be useful

@WebSpider
Copy link
Contributor

Thanks for the fixture!

It looks like the fixture is breaking some tests, interesting!

@WebSpider
Copy link
Contributor

Can you please re-run the fixtures with the most recent version of the software? Thanks!

@bjacquot
Copy link
Contributor Author

bjacquot commented Dec 19, 2024 •
edited
Loading

of course, but i'm not sure about what you mean.
mySkoda software version or homeassistant ?

homeAssistant 24.11
myskoda-24_11.json

homeAssistant 24.12
myskoda-24_12.json

@prvakt
Copy link
Collaborator

prvakt commented Dec 19, 2024

fixtures must be pushed in yaml format not json... please use some json to yaml converter first.. or if you want I can do it for you ;)

prvakt
prvakt requested changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@prvakt prvakt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

json must be converted to yaml.. please use my suggested changes, it should work afterwards

fixtures/citigoe_iv_2020_ne14e2_style.yaml Outdated Show resolved Hide resolved
@prvakt prvakt merged commit 4191701 into skodaconnect:main Dec 19, 2024
2 checks passed
@prvakt
Copy link
Collaborator

prvakt commented Dec 19, 2024

I was able to fix it within this PR myself, but thanks for the fixtures !

@bjacquot
Copy link
Contributor Author

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prvakt prvakt prvakt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bjacquot @WebSpider @prvakt