Introduce exponential backoff for MQTT reconnect #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er if it is in an error state
dvx76
reviewed
Dec 5, 2024
dvx76
approved these changes
Dec 5, 2024
zaptm
pushed a commit
to zaptm/myskoda
that referenced
this pull request
Dec 8, 2024
* Make MQTT reconnect backoff exponential so we do not hammer MQTT server if it is in an error state * Add self._reconnect_delay to init. Reset only upon succesfull complete subscribe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes MQTT reconnect backoff exponential so we do not hammer MQTT server if it is in an error state.
Observed in todays MQTT outage that we reconnect every 5s, which is very rapid when running this distributed and at scale.
We do not need to DOS the MQTT server while trying to get our updates, so implementing an industry-standard solution (exponential backoff with jitter) to this, seems like a reasonable addition.