Fix Auxiliary Heater for ICE, add outside_temperature #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 3, 2024 10:15
added AUXILIARY_HEATING_BASIC capability added targetTemperature to AuxiliaryHeating class added auxiliary_heating object to vehicle added request for auxiliary_heating into get_vehicle()
WebSpider
reviewed
Dec 3, 2024
WebSpider
changed the title
WebSpider
approved these changes
Dec 3, 2024
zaptm
pushed a commit
to zaptm/myskoda
that referenced
this pull request
Dec 8, 2024
* added AUXILIARY_HEATING_BASIC capability * added targetTemperature to AuxiliaryHeating class * added auxiliary_heating object to vehicle * added request for auxiliary_heating into get_vehicle() * fixtures updated --------- Co-authored-by: Tomas Prvak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a difference between how state from auxiliary heater can be obtained between ICE and PHEV
state="INVALID"independent on the real state. Because of that, we must retrieve state from auxiliary-heating endpoint. Because of that, auxiliary-heating data have been added to the Vehicle class and can be retrieved via get_vehicle()