Expose fetchRegions() to allow handling error (#307)

skedgo · Sep 21, 2023 · 1108d6f · 1108d6f
1 parent 04118f0
commit 1108d6f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/Sources/TripKit/managers/TKRegionManager.swift b/Sources/TripKit/managers/TKRegionManager.swift
@@ -40,8 +40,8 @@ public class TKRegionManager: NSObject {
       let response = try JSONDecoder().decode(TKAPI.RegionsResponse.self, from: data)
       updateRegions(from: response)
     } catch {
-      assertionFailure()
       TKLog.warn("Couldn't load regions from cache: \(error)")
+      assertionFailure()
     }
   }
 

diff --git a/Sources/TripKit/server/TKServer+Regions.swift b/Sources/TripKit/server/TKServer+Regions.swift
@@ -17,14 +17,16 @@ extension TKRegionManager {
 
   /// Fetched the list of regions and updates `TKRegionManager`'s cache
   ///
+  /// Equivalent to `updateRegions(forced:) async throws`, but ignores the error.
+  ///
   /// Recommended to call from the application delegate.
   /// - Parameter forced: Set true to force overwriting the internal cache
   public func updateRegions(forced: Bool = false) {
     Task {
       try? await fetchRegions(forced: forced)
     }
   }
-  
+
   @available(*, renamed: "requireRegions()")
   public func requireRegions(completion: @escaping (Result<Void, Error>) -> Void) {
     guard !hasRegions else {
@@ -46,7 +48,13 @@ extension TKRegionManager {
     }
   }
 
-  private func fetchRegions(forced: Bool) async throws {
+  /// Fetched the list of regions and updates `TKRegionManager`'s cache
+  ///
+  /// Equivalent to `updateRegions(forced:)`.
+  ///
+  /// Recommended to call from the application delegate.
+  /// - Parameter forced: Set true to force overwriting the internal cache
+  public func fetchRegions(forced: Bool) async throws {
     let regionsURL: URL
     if let customBaseURL = TKServer.customBaseURL {
       guard let url = URL(string: customBaseURL) else {