Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Rails.application.deprecators.silence for rails >= 7.1 #58

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

Aqualon
Copy link
Collaborator

@Aqualon Aqualon commented Sep 27, 2024

This fixes #54 and shows errors again that are just lost atm for apps that already went to rails 7.2.x.

Rails.application.deprecators was added with rails 7.1, so have to keep the old way for previous versions
https://github.com/rails/rails/blob/15ddce90583bdf169ae69449b42db10be9f714c9/guides/source/7_1_release_notes.md?plain=1#L18

@skaes could you please check and merge/release a new version?

@skaes skaes merged commit f356fcf into skaes:master Sep 27, 2024
3 checks passed
@Aqualon Aqualon deleted the 7_2_compatibility branch October 7, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calling silence on ActiveSupport::Deprecation is deprecated and will be removed from Rails
2 participants