Modify routing event handling to do nothing if navigation is cancelled (

#200) Co-authored-by: Jean-François Chaput <[email protected]>
single-spa · Oct 2, 2023 · deb1e37 · deb1e37
1 parent 50b6918
commit deb1e37
Showing 1 changed file with 12 additions and 9 deletions.
diff --git a/src/browser/constructLayoutEngine.js b/src/browser/constructLayoutEngine.js
@@ -206,15 +206,18 @@ export function constructLayoutEngine({
     });
   }
 
-  function handleRoutingEvent({ detail: { newUrl } }) {
-    getAppsToUnmount(newUrl).forEach((name) => {
-      const applicationElement = document.getElementById(
-        applicationElementId(name)
-      );
-      if (applicationElement && applicationElement.isConnected) {
-        applicationElement.parentNode.removeChild(applicationElement);
-      }
-    });
+  function handleRoutingEvent({ detail: { navigationIsCanceled, newUrl } }) {
+    // only unmount if navigation is not cancelled
+    if (!navigationIsCanceled) {
+      getAppsToUnmount(newUrl).forEach((name) => {
+        const applicationElement = document.getElementById(
+          applicationElementId(name)
+        );
+        if (applicationElement && applicationElement.isConnected) {
+          applicationElement.parentNode.removeChild(applicationElement);
+        }
+      });
+    }
   }
 }