Tdl 15582 check best practices #78
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbshah1212
approved these changes
Oct 27, 2021
karanpanchal-crest
approved these changes
Nov 1, 2021
KrisPersonal
approved these changes
Nov 2, 2021
KrisPersonal
approved these changes
Nov 8, 2021
kspeer825
suggested changes
Nov 8, 2021
test/base.py
Outdated
Comment on lines
118
to
122
| "ticket_metrics": { | ||
| self.PRIMARY_KEYS: {"id"}, | ||
| self.REPLICATION_METHOD: self.INCREMENTAL, | ||
| self.REPLICATION_KEYS: set() | ||
| }, |
There was a problem hiding this comment.
ticket_comments is child stream of tickets, and tickets is incremental stream. But ticket_comments does not save its own bookmark. It fetches records based on the record of the parent stream. That's why it is incremental but does not have a replication key.
test/base.py
Outdated
Comment on lines
133
to
137
| "ticket_audits": { | ||
| self.PRIMARY_KEYS: {"id"}, | ||
| self.REPLICATION_METHOD: self.INCREMENTAL, | ||
| self.REPLICATION_KEYS: set() | ||
| } |
There was a problem hiding this comment.
ticket_comments is child stream of tickets, and tickets is incremental stream. But ticket_comments does not save its own bookmark. It fetches records based on the record of the parent stream. That's why it is incremental but does not have a replication key.
kspeer825
suggested changes
Nov 9, 2021
kspeer825
approved these changes
Nov 10, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Manual QA steps
Risks
Rollback steps