Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TDL-26578 Fix custom field date time schema #151

Open
wants to merge 2 commits into
base: TDL-24687/enhance-tap-performance
Choose a base branch
from
Open

TDL-26578 Fix custom field date time schema #151

wants to merge 2 commits into from

Conversation

bryantgray
Copy link
Contributor

Description of change

  • Changes custom date types to use the valid json schema format date-time instead of the invalid datetime.

Manual QA steps

  • Verified schema produced by discovery has date-time format for custom firlds

Risks

  • Changing the json schema formatdatetime to date-time may cause these fields to be treated differently downstream because date-time is a valid format in the json schema spec.

Rollback steps

  • revert this branch

AI generated code

https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code

  • this PR has been written with the help of GitHub Copilot or another generative AI tool

@bryantgray bryantgray changed the base branch from TDL-24687/enhance-tap-performance to master December 11, 2024 18:47
@bryantgray bryantgray changed the base branch from master to TDL-24687/enhance-tap-performance December 11, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bryantgray