Remove chat_only field from expectations again (#145)

singer-io · Dec 20, 2023 · 4d8bde1 · 4d8bde1
1 parent e7a6669
commit 4d8bde1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/test/test_all_fields.py b/test/test_all_fields.py
@@ -72,8 +72,8 @@ def test_run(self):
                 # As we can't generate following fields by zendesk APIs now so expected.
                 if stream == "ticket_fields":
                     expected_all_keys = expected_all_keys - {'system_field_options', 'sub_type_id'}
-                # elif stream == "users":  # field started appearing in syncd records Nov 1, 2023
-                #     expected_all_keys = expected_all_keys - {'chat_only'}
+                elif stream == "users":  # field appeared in syncd records Nov 1 - Dec 18, 2023
+                    expected_all_keys = expected_all_keys - {'chat_only'}
                 elif stream == "ticket_metrics":
                     expected_all_keys = expected_all_keys - {'status', 'instance_id', 'metric', 'type', 'time'}
                 elif stream == "talk_phone_numbers":

diff --git a/test/test_lookup_fields.py b/test/test_lookup_fields.py
@@ -45,8 +45,8 @@ def test_run(self):
                                           for md_entry in catalog_entry['metadata']
                                           if md_entry['breadcrumb'] != []]
             fields_from_field_level_md += lookup_fields_map[stream_name]
-            # if stream_name == "users":  # field started appearing in syncd records Nov 1, 2023
-            #     fields_from_field_level_md.remove("chat_only")
+            if stream_name == "users":  # field appeared in syncd records Nov 1 - Dec 18, 2023
+                fields_from_field_level_md.remove("chat_only")
             stream_to_all_catalog_fields[stream_name] = set(fields_from_field_level_md)
 
         self.run_and_verify_sync(conn_id)