Tdl 20778 code refactoring #45

somethingmorerelevant · 2022-10-18T11:31:09Z

Description of change

Improved directory structure
Added pagination support to BANS stream
Fixed unit tests
Added typehints and docstrings.
Added pre-commit integration.
FIX for following issues

Manual QA steps

Run unit test cases
Run integration test cases

Risks

Rollback steps

revert this branch

1) modified discovery unit tests.

1) Fixed unittests as per new code refactoring changes.

…-zendesk-chat into TDL_20778_code_refactoring

1) Removed unused import from init file. 2) Fixed bookmarks test.

tap_zendesk_chat/context.py

tap_zendesk_chat/__init__.py

tap_zendesk_chat/http.py

tap_zendesk_chat/utils.py

tap_zendesk_chat/streams.py

tap_zendesk_chat/discover.py

tap_zendesk_chat/__init__.py

tap_zendesk_chat/streams.py

* add automation fields * fixed import * fixed test * added test for all_fields and automatic fields * added base for interuptible sync * formatted tests and added interuptible sync * added pagination test * fix bookmark test * fixed bookmark test * fixed issue with 400 * fixed integration test messages * added exception to chats stream * fixed automatic field for chats stream * fixed formatting changes * fixed missing key issue * updated automatic fields test * fixed auto field condition * fixed pylint issue

tests/base.py

tests/test_all_fields.py

tests/test_automatic_fields.py

tests/test_interupted_sync.py

tests/test_pagination.py

tests/test_interupted_sync.py

tests/test_all_fields.py

tests/test_automatic_fields.py

tests/test_pagination.py

RushiT0122

Requested changes in-line.

tests/test_automatic_fields.py

tests/test_all_fields.py

tests/test_automatic_fields.py

somethingmorerelevant and others added 16 commits September 28, 2022 09:57

added pre-commit

eaa1eb6

added pre-commit and updated gitignore

30bfd30

updated file structure

44f6da2

updated init for tap

0c62c08

fixed sync.py

8ecb433

fixed discovery

bae0e69

fixed streams

f2e9799

removed pendulum dependancy

b8019df

added pagination support to bans stream

7529d9a

pylint and formatting issues

76ba0f7

Changes:

3bb5766

1) modified discovery unit tests.

Changes:

9abfd9d

1) Fixed unittests as per new code refactoring changes.

removed dependancy of unittest on pendulum library

5b71144

added typehints and docstrings

ab00310

Merge branch 'TDL_20778_code_refactoring' of github.com:singer-io/tap…

270e013

…-zendesk-chat into TDL_20778_code_refactoring

Changes:

cd1822b

1) Removed unused import from init file. 2) Fixed bookmarks test.

somethingmorerelevant marked this pull request as ready for review October 18, 2022 13:17

kethan1122 reviewed Oct 19, 2022

View reviewed changes

somethingmorerelevant added 7 commits November 3, 2022 08:16

added config param for bans stream page size

c0f6db5

added warning for 400 exception

3edd865

fixed schema issues

2c2c5cb

added replication method to catalog

9a22a35

fixed automatic fields issue

24afc7e

fixed discovery changes

d0b5e4b

fixed pylint issue

c435e42

kethan1122 reviewed Nov 11, 2022

View reviewed changes

tap_zendesk_chat/streams.py Outdated Show resolved Hide resolved

kethan1122 reviewed Nov 11, 2022

View reviewed changes

tap_zendesk_chat/discover.py Outdated Show resolved Hide resolved

tap_zendesk_chat/__init__.py Outdated Show resolved Hide resolved

tap_zendesk_chat/streams.py Outdated Show resolved Hide resolved

somethingmorerelevant added 3 commits November 11, 2022 18:00

created classes for each stream

8e2e05c

minor enhancements

1796c45

fixed review comments

39661eb

somethingmorerelevant and others added 4 commits November 14, 2022 16:30

fixed pylint issues

4273e78

Fixed bookmark tests.

d4df3f1

removed singer method from context

2a1adac