Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TDL-25850] Add backoff for client error 406 #181

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

shantanu73
Copy link
Contributor

@shantanu73 shantanu73 commented May 29, 2024

Description of change

  1. Added retry for 406 Client Error
  2. Added unit test case for 406 Client Error

QA steps

  • automated tests passing
  • manual qa steps passing (list below)

Risks

  • low risk

Rollback steps

  • revert this branch

@shantanu73 shantanu73 changed the title Add backoff for client error 406 [TDL-25850] Add backoff for client error 406 May 29, 2024
main()

# verify "LOGGER.critical" is called once
self.assertEqual(mocked_logger_critical.call_count, 1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please verify if the retry count exceeds 1. Note that within the tap code, the maximum retry limit is configured to 10.

1) Fixed the exception condition in _make_request method for 406 error.
2) Fixed unit test for 406 error as per review comments.
@sgandhi1311
Copy link
Member

The changes look good to me. Can we get the integration test fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants