TDL-6301: Add new stream CustomerType (Copy of PR #19) #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpatel41
requested review from
dbshah1212,
karanpanchal-crest and
savan-chovatiya
dbshah1212
approved these changes
Sep 9, 2022
savan-chovatiya
approved these changes
Sep 9, 2022
RushiT0122
requested review from
rdeshmukh15
and removed request for
RushiT0122
rdeshmukh15
approved these changes
Sep 26, 2022
…books into TDL-6301-add-customertype-stream
Merged
sgandhi1311
added a commit
that referenced
this pull request
Nov 30, 2022
* TDL-20058: Add missing integration tests. (#61) * Added missing assersions in tap-tester tests * updated tap-tester tests * added docstring for test case classes * updated test cases Co-authored-by: harshpatel4crest <[email protected]> * TDL-13906: Update README.md (#60) * updated readme file, init and added unittest * updated config.yml file * added logger for sync mode * formatted unitttests * TDL-20063: Add unit test cases (#59) * added unittest of sync.py * updated config.yml file * added unittest for unknown stream sync and updated sync code * updated unittests * formatted unittest * TDL-20061: Added missing fields (#58) * Added missing fields & add shared schema * Updated types * Updated types * Reverted datatype for some fields * Updated datatype for QtyOnHand Co-authored-by: harshpatel4crest <[email protected]> * TDL-20062: Add minor version in API requests (#57) * Added minor version in requests * Added unit tests * Removed workaround for some fields as minorversion is added * Fixed all field test * Updated code comment * resolved unittest failure Co-authored-by: harshpatel4crest <[email protected]> * TDL-20057: Add custom exception handling (#56) * added exception handling * added parameterized import in config.yml file * updated test case name * handled other 4XX error and updated test cases * added test case * updated test case * added pylint * updated formatting * formatted test case * TDL-20059: Implement currently_syncing (#55) * added currently syncing functionality * added interrupted sync tap-tester test * updated test case * Updated the tests method to use common test name to use token chaining * Updated the test method to use common test name to use token chaining * updated interrupted sync test * updated interrupted sync test * added docstring for test case name * updated comment indentation * updated tap-tester tests * updated interrupted sync test case * updated interrupted sync test case * formatted test case * resolve unittest failure Co-authored-by: RushT007 <[email protected]> * added new stream CustomerType (#62) * Fixing the review comments * changes - - removed currently syncing unit test case. - In interrupt sync, made changes according to review comments * replaced print with logger * added docstring to the tests * removed pagination assertion from automatic_fields test * improve readability * fix the doc string formatting * generate state file dynamically instead of having a static state dictionary * remove duplicate test cases * removed init.py from tests * Update tap version to 2.0.0 and update the changelog Co-authored-by: savan-chovatiya <[email protected]> Co-authored-by: RushT007 <[email protected]> Co-authored-by: Sourabh Gandhi <[email protected]>
sgandhi1311
added a commit
that referenced
this pull request
Jan 12, 2023
* TDL-20058: Add missing integration tests. (#61) * Added missing assersions in tap-tester tests * updated tap-tester tests * added docstring for test case classes * updated test cases Co-authored-by: harshpatel4crest <[email protected]> * TDL-13906: Update README.md (#60) * updated readme file, init and added unittest * updated config.yml file * added logger for sync mode * formatted unitttests * TDL-20063: Add unit test cases (#59) * added unittest of sync.py * updated config.yml file * added unittest for unknown stream sync and updated sync code * updated unittests * formatted unittest * TDL-20061: Added missing fields (#58) * Added missing fields & add shared schema * Updated types * Updated types * Reverted datatype for some fields * Updated datatype for QtyOnHand Co-authored-by: harshpatel4crest <[email protected]> * TDL-20062: Add minor version in API requests (#57) * Added minor version in requests * Added unit tests * Removed workaround for some fields as minorversion is added * Fixed all field test * Updated code comment * resolved unittest failure Co-authored-by: harshpatel4crest <[email protected]> * TDL-20057: Add custom exception handling (#56) * added exception handling * added parameterized import in config.yml file * updated test case name * handled other 4XX error and updated test cases * added test case * updated test case * added pylint * updated formatting * formatted test case * TDL-20059: Implement currently_syncing (#55) * added currently syncing functionality * added interrupted sync tap-tester test * updated test case * Updated the tests method to use common test name to use token chaining * Updated the test method to use common test name to use token chaining * updated interrupted sync test * updated interrupted sync test * added docstring for test case name * updated comment indentation * updated tap-tester tests * updated interrupted sync test case * updated interrupted sync test case * formatted test case * resolve unittest failure Co-authored-by: RushT007 <[email protected]> * added new stream CustomerType (#62) * Implemented dev mode for tap-quickbooks * Make pylint happy * Reducing the instance attributes and updated the pylint disable with too-many-instance-attributes * added new test cases for dev mode * Fixing the review comments * (dev-mode) Removing the expires_at key and modifiying the logic accordingly. * Make pylint happy * update singer-python version * remove the extra test file * Remove the unit test for currently syncing as it is already getting tested in interrupt sync * pass the arguments while creating the QuickbooksClient * Reformat code * Update setup.py and changelog.md for dev mode support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
TDL-6301: Add new stream CustomerType (Copy of PR #19)
Manual QA steps
Risks
Rollback steps