Fix unnecessary re-fetching of pull request data #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub’s /pulls endpoint doesn’t have a ?since filter, so instead we check the updated_at values of each record imported. Since we have sorted descending by this value, we can break out of the loop once we have found the first updated_at value that is less than the bookmark time. Fixes singer-io#43
|
👍 |
AJWurts
pushed a commit
to villagelabsco/tap-github
that referenced
this pull request
Oct 24, 2024
GitHub’s /pulls endpoint doesn’t have a ?since filter, so instead we check the updated_at values of each record imported. Since we have sorted descending by this value, we can break out of the loop once we have found the first updated_at value that is less than the bookmark time. Fixes singer-io#43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub’s /pulls endpoint doesn’t have a ?since filter, so instead we
check the updated_at values of each record imported. Since we have
sorted descending by this value, we can break out of the loop once we
have found the first updated_at value that is less than the bookmark
time.
Fixes #43