-
-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Transgender #2949
base: main
Are you sure you want to change the base?
Add Transgender #2949
Conversation
Thanks for making an Awesome list! 🙌 It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome. |
@cvyl These are the requirements I found the PR and the list haven't meet (wish it would be helpful for you): Requirements for your pull request
Requirements for your Awesome list
|
I am unable to understand the following error: EDIT: I fixed it. It passes the lint. |
Requesting @sindresorhus to review the changes made. |
I noticed that illustration requirement is not fulfilled, so maybe add a trans flag logo as illustration? |
c05ec08
to
bbe1e6f
Compare
Hello, I'd love to receive an update on this PR's review |
Once again, requesting an update. |
|
|
|
Many items are missing a description. |
Thank you for your review, I will fix these issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually after reviewing it looks life you fixed the lint issues but not the problems listed by sindresorhus.
I would advise you to fix them. (f.ex. Objects having no description
)
I did not mean to approve this pull request for the reasons stated in this comment.
f0658c5
to
993cee4
Compare
This is an important topic! |
@sindresorhus @menisadi, I have updated the README with the changes that were requested. Please review the modifications at your convenience. Thank you very much for your time and consideration. |
I've resolved the listing to the newest commit. |
Great. Looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your entry here should include a short description of the project/theme of the list. It should not describe the list itself.
For this requirement, your entry should describe/define the theme (in this case, transgender), not the list itself.
Includes a succinct description of the project/theme at the top of the readme.
You should also include a definition/description of 'transgender' at the top of the readme. You could add it below the description of the list, like this.
Other than that, everything looks great. Good job!
Co-authored-by: Isabela de Matos <[email protected]>
I have updated the readme to your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Includes a succinct description of the project/theme at the top of the readme.
You should also include a definition/description of 'transgender' at the top of the readme. You could add it below the description of the list, like this.
Hi, I don't see this change in the readme.
My apologies, it should be updated now. Does this suffice? |
Everything looks good now! |
@sindresorhus |
https://github.com/cvyl/awesome-transgender
Why
I think adding a resource list for LGBTQ+/Transgender individuals under the health section is appropriate and will help those on GitHub or those who are passing by find the best resources closest to them. I hope to help others by including this addition.
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request
Don't open a Draft / WIP pull request while you work on the guidelines. A pull request should be 100% ready and should adhere to all the guidelines when you open it. Instead use #2242 for incubation visibility.
Don't waste my time. Do a good job, adhere to all the guidelines, and be responsive.
You have to review at least 2 other open pull requests.
Add Red-Teaming LLMs #3247 (review)
Add WebGPU #3210 (review)
Add RT-Thread #3048 (comment)
@KAPKYK #3296 (review)
Add Permacomputing #3293 (review)
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration. Just commenting “looks good” or simply marking the pull request as approved does not count! You have to actually point out mistakes or improvement suggestions. Comments pointing out lint violation are allowed, but does not count as a review.
You have read and understood the instructions for creating a list.
This pull request has a title in the format
Add Name of List
. It should not contain the wordAwesome
.Add Swift
Add Software Architecture
Update readme.md
Add Awesome Swift
Add swift
add Swift
Adding Swift
Added Swift
Your entry here should include a short description of the project/theme of the list. It should not describe the list itself. The first character should be uppercase and the description should end in a dot. It should be an objective description and not a tagline or marketing blurb. It should not contain the name of the list.
- [iOS](…) - Mobile operating system for Apple phones and tablets.
- [Framer](…) - Prototyping interactive UI designs.
- [iOS](…) - Resources and tools for iOS development.
- [Framer](…)
- [Framer](…) - prototyping interactive UI designs
Your entry should be added at the bottom of the appropriate category.
The title of your entry should be title-cased and the URL to your list should end in
#readme
.- [Software Architecture](https://github.com/simskij/awesome-software-architecture#readme) - The discipline of designing and building software.
No blockchain-related lists.
The suggested Awesome list complies with the below requirements.
Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-lint
on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.main
, notmaster
.Mobile operating system for Apple phones and tablets.
Prototyping interactive UI designs.
Resources and tools for iOS development.
Awesome Framer packages and tools.
If you have not put in considerable effort into your list, your pull request will be immediately closed.
awesome-name-of-list
.awesome-swift
awesome-web-typography
awesome-Swift
AwesomeWebTypography
# Awesome Name of List
.# Awesome Swift
# Awesome Web Typography
# awesome-swift
# AwesomeSwift
awesome-list
&awesome
as GitHub topics. I encourage you to add more relevant topics.Awesome X
and a logo withAwesome X
. You can put the header image in a#
(Markdown header) or<h1>
.Contents
, notTable of Contents
.Contributing
orFootnotes
sections.https://github.com/<user>/<repo>/community/license/new?branch=main&template=cc0-1.0
(replace<user>
and<repo>
accordingly).license
orLICENSE
in the repo root with the license text.Licence
section to the readme. GitHub already shows the license name and link to the full text at the top of the repo.unicorn
.contributing.md
. The casing is up to you.Contributing
, positioned at the top or bottom of the main content.Footnotes
section at the bottom of the readme. The section should not be present in the Table of Contents.Example:
- [AVA](…) - JavaScript test runner.
Node.js
, notNodeJS
ornode.js
.You can still use a CI for linting, but the badge has no value in the readme.
Inspired by awesome-foo
orInspired by the Awesome project
kinda link at the top of the readme. The Awesome badge is enough.Go to the top and read it again.