-
-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ComputerCraft #2405
Add ComputerCraft #2405
Conversation
unicorn 🦄 |
|
#economy is linked twice in the TOC. It looks like the second instance should be linked to #economy-1. |
Fixed, thanks for pointing this out. |
@paulbradish it's been a little over a month since I submitted this PR, is the maintainer inactive? |
@tomodachi94 I'm pretty sure they are still active because I submitted a PR yesterday to a failed response. What I'm not clear on after reading the directions again is if we need to submit a new PR after all of the updates have been made or if we can use the original. |
Probably just use the same PR. If it was closed, reopen it when you're ready. |
@sindresorhus, I hate to ping you, but this PR has been sitting idle for two and a half months (and the list has existed upwards of three and a half). I've noticed you've responded to several other PRs, is there something wrong with this PR? |
|
|
This should be removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please reformat the file
This was the highest-quality image of the logo I could find. |
Co-authored-by: andrzejsydor <[email protected]>
The link at the top to the contributing guidelines is valid, I'm not sure why the linter is complaining. I am not using emphasis to introduce a section, I am using emphasis... to give emphasis.
I'm not sure what to do with linking a multi-part series like this: Lyqyd's *Computer Basics* series ([I](https://linktopart.1), [II](https://linktopart.2), [III](https://linktopart.3)) - *snip* (Edit: I ran the linter a few weeks ago and fixed a lot of issues.) |
Removed at the recommendation of @sindresorhus. Discussion: sindresorhus/awesome#2405 (comment)
I have just removed it. |
@sindresorhus I believe I've satisfied all of the requirements, could you re-review this PR? |
The linting is stil failing |
@sindresorhus I fixed some things, the linter should pass. Also, now there's a GitHub Actions check for |
Co-authored-by: Sindre Sorhus <[email protected]> Update desription
https://github.com/tomodachi94/awesome-computercraft
ComputerCraft is a Minecraft mod which adds programmable computers to the game.
Reviewed PRs:
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration. Just commenting “looks good” or simply marking the pull request as approved does not count! You have to actually point out mistakes or improvement suggestions.
Add Name of List
.Add Swift
Add Software Architecture
Update readme.md
Add Awesome Swift
Add swift
add Swift
Adding Swift
Added Swift
- [iOS](…) - Mobile operating system for Apple phones and tablets.
- [Framer](…) - Prototyping interactive UI designs.
- [iOS](…) - Resources and tools for iOS development.
- [Framer](…)
- [Framer](…) - prototyping interactive UI designs
#readme
.- [Software Architecture](https://github.com/simskij/awesome-software-architecture#readme) - The discipline of designing and building software.
Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-lint
on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.main
, notmaster
.Mobile operating system for Apple phones and tablets.
Prototyping interactive UI designs.
Resources and tools for iOS development.
Awesome Framer packages and tools.
If you have not put in considerable effort into your list, your pull request will be immediately closed.
awesome-name-of-list
.awesome-swift
awesome-web-typography
awesome-Swift
AwesomeWebTypography
# Awesome Name of List
.# Awesome Swift
# Awesome Web Typography
# awesome-swift
# AwesomeSwift
awesome-list
&awesome
as GitHub topics. I encourage you to add more relevant topics.Contents
, notTable of Contents
.Contributing
orFootnotes
sections.https://github.com/<user>/<repo>/community/license/new?branch=main&template=cc0-1.0
(replace<user>
and<repo>
accordingly).license
orLICENSE
in the repo root with the license text.Licence
section to the readme. GitHub already shows the license name and link to the full text at the top of the repo.unicorn
.contributing.md
. Casing is up to you.Contributing
, positioned at the top or bottom of the main content.Footnotes
section at the bottom of the readme. The section should not be present in the Table of Contents.Example:
- [AVA](…) - JavaScript test runner.
Node.js
, notNodeJS
ornode.js
.You can still use Travis for list linting, but the badge has no value in the readme.
Inspired by awesome-foo
orInspired by the Awesome project
kinda link at the top of the readme. The Awesome badge is enough.Go to the top and read it again.