Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ComputerCraft #2405

Merged
merged 3 commits into from
Feb 3, 2023
Merged

Add ComputerCraft #2405

merged 3 commits into from
Feb 3, 2023

Conversation

tomodachi94
Copy link
Contributor

@tomodachi94 tomodachi94 commented Oct 8, 2022

https://github.com/tomodachi94/awesome-computercraft

ComputerCraft is a Minecraft mod which adds programmable computers to the game.

Reviewed PRs:

By submitting this pull request I confirm I've read and complied with the below requirements 🖖

Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.

Requirements for your pull request

  • Don't waste my time. Do a good job, adhere to all the guidelines, and be responsive.
  • You have to review at least 2 other open pull requests.
    Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration. Just commenting “looks good” or simply marking the pull request as approved does not count! You have to actually point out mistakes or improvement suggestions.
  • You have read and understood the instructions for creating a list.
  • This pull request has a title in the format Add Name of List.
    • Add Swift
    • Add Software Architecture
    • Update readme.md
    • Add Awesome Swift
    • Add swift
    • add Swift
    • Adding Swift
    • Added Swift
  • Your entry here should include a short description about the project/theme of the list. It should not describe the list itself. The first character should be uppercase and the description should end in a dot. It should be an objective description and not a tagline or marketing blurb.
    • - [iOS](…) - Mobile operating system for Apple phones and tablets.
    • - [Framer](…) - Prototyping interactive UI designs.
    • - [iOS](…) - Resources and tools for iOS development.
    • - [Framer](…)
    • - [Framer](…) - prototyping interactive UI designs
  • Your entry should be added at the bottom of the appropriate category.
  • The title of your entry should be title-cased and the URL to your list should end in #readme.
    • Example: - [Software Architecture](https://github.com/simskij/awesome-software-architecture#readme) - The discipline of designing and building software.
  • The suggested Awesome list complies with the below requirements.

Requirements for your Awesome list

  • Has been around for at least 30 days.
    That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
  • Don't open a Draft / WIP pull request while you work on the guidelines. A pull request should be 100% ready and should adhere to all the guidelines when you open it. Instead use #2242 for incubation visibility.
  • Run awesome-lint on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.
  • The default branch should be named main, not master.
  • Includes a succinct description of the project/theme at the top of the readme. (Example)
    • Mobile operating system for Apple phones and tablets.
    • Prototyping interactive UI designs.
    • Resources and tools for iOS development.
    • Awesome Framer packages and tools.
  • It's the result of hard work and the best I could possibly produce.
    If you have not put in considerable effort into your list, your pull request will be immediately closed.
  • The repo name of your list should be in lowercase slug format: awesome-name-of-list.
    • awesome-swift
    • awesome-web-typography
    • awesome-Swift
    • AwesomeWebTypography
  • The heading title of your list should be in title case format: # Awesome Name of List.
    • # Awesome Swift
    • # Awesome Web Typography
    • # awesome-swift
    • # AwesomeSwift
  • Non-generated Markdown file in a GitHub repo.
  • The repo should have awesome-list & awesome as GitHub topics. I encourage you to add more relevant topics.
  • Not a duplicate. Please search for existing submissions.
  • Only has awesome items. Awesome lists are curations of the best, not everything.
  • Does not contain items that are unmaintained, has archived repo, deprecated, or missing docs. If you really need to include such items, they should be in a separate Markdown file.
  • Includes a project logo/illustration whenever possible.
    • Either centered, fullwidth, or placed at the top-right of the readme. (Example)
    • The image should link to the project website or any relevant website.
    • The image should be high-DPI. Set it to maximum half the width of the original image.
  • Entries have a description, unless the title is descriptive enough by itself. It rarely is though.
  • Includes the Awesome badge.
    • Should be placed on the right side of the readme heading.
      • Can be placed centered if the list has a centered graphics header.
    • Should link back to this list.
  • Has a Table of Contents section.
    • Should be named Contents, not Table of Contents.
    • Should be the first section in the list.
    • Should only have one level of nested lists, preferably none.
    • Must not feature Contributing or Footnotes sections.
  • Has an appropriate license.
    • We strongly recommend the CC0 license, but any Creative Commons license will work.
      • Tip: You can quickly add it to your repo by going to this URL: https://github.com/<user>/<repo>/community/license/new?branch=main&template=cc0-1.0 (replace <user> and <repo> accordingly).
    • A code license like MIT, BSD, Apache, GPL, etc, is not acceptable. Neither are WTFPL and Unlicense.
    • Place a file named license or LICENSE in the repo root with the license text.
    • Do not add the license name, text, or a Licence section to the readme. GitHub already shows the license name and link to the full text at the top of the repo.
    • To verify that you've read all the guidelines, please comment on your pull request with just the word unicorn.
  • Has contribution guidelines.
    • The file should be named contributing.md. Casing is up to you.
    • It can optionally be linked from the readme in a dedicated section titled Contributing, positioned at the top or bottom of the main content.
    • The section should not appear in the Table of Contents.
  • All non-important but necessary content (like extra copyright notices, hyperlinks to sources, pointers to expansive content, etc) should be grouped in a Footnotes section at the bottom of the readme. The section should not be present in the Table of Contents.
  • Has consistent formatting and proper spelling/grammar.
    • The link and description are separated by a dash.
      Example: - [AVA](…) - JavaScript test runner.
    • The description starts with an uppercase character and ends with a period.
    • Consistent and correct naming. For example, Node.js, not NodeJS or node.js.
  • Doesn't use hard-wrapping.
  • Doesn't include a Travis badge.
    You can still use Travis for list linting, but the badge has no value in the readme.
  • Doesn't include an Inspired by awesome-foo or Inspired by the Awesome project kinda link at the top of the readme. The Awesome badge is enough.

Go to the top and read it again.

@tomodachi94
Copy link
Contributor Author

unicorn 🦄

@tomodachi94
Copy link
Contributor Author

tomodachi94 commented Oct 8, 2022

A large amount of items on the list don't have one definitive URL... what should I do? Fixed this by finding definitive URLs and placing those in the right spot.

@paulbradish
Copy link

#economy is linked twice in the TOC. It looks like the second instance should be linked to #economy-1.

@tomodachi94
Copy link
Contributor Author

#economy is linked twice in the TOC. It looks like the second instance should be linked to #economy-1.

Fixed, thanks for pointing this out.

@tomodachi94
Copy link
Contributor Author

@paulbradish it's been a little over a month since I submitted this PR, is the maintainer inactive?

@paulbradish
Copy link

@tomodachi94 I'm pretty sure they are still active because I submitted a PR yesterday to a failed response. What I'm not clear on after reading the directions again is if we need to submit a new PR after all of the updates have been made or if we can use the original.

@tomodachi94
Copy link
Contributor Author

I'm pretty sure they are still active because I submitted a PR yesterday to a failed response. What I'm not clear on after reading the directions again is if we need to submit a new PR after all of the updates have been made or if we can use the original.

Probably just use the same PR. If it was closed, reopen it when you're ready.

@tomodachi94
Copy link
Contributor Author

tomodachi94 commented Nov 19, 2022

@sindresorhus, I hate to ping you, but this PR has been sitting idle for two and a half months (and the list has existed upwards of three and a half). I've noticed you've responded to several other PRs, is there something wrong with this PR?

@sindresorhus
Copy link
Owner

❯ awesome-lint 'https://github.com/tomodachi94/awesome-computercraft'
✖ Linting

  README.md:9:1
  ✖    1:1    Invalid URL: ./CONTRIBUTING.md                                remark-lint:double-link
  ✖    9:1    Don’t use emphasis to introduce a section, use a heading      remark-lint:no-emphasis-as-heading
  ✖  184:137  List item link and description must be separated with a dash  remark-lint:awesome-list-item
  ✖  200:4    Should not repeat "~"                                         remark-lint:no-repeat-punctuation
  ✖  200:116  Should not repeat "~"                                         remark-lint:no-repeat-punctuation

  5 errors

https://github.com/sindresorhus/awesome-lint

@sindresorhus
Copy link
Owner

The image should be high-DPI. Set it to maximum half the width of the original image.

@sindresorhus
Copy link
Owner

CC's original wiki - Contains some useful legacy information. Considered deprecated by modern standards.

This should be removed.

readme.md Outdated Show resolved Hide resolved
Copy link

@andrzejsydor andrzejsydor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please reformat the file

@tomodachi94
Copy link
Contributor Author

The image should be high-DPI. Set it to maximum half the width of the original image.

This was the highest-quality image of the logo I could find.

Co-authored-by: andrzejsydor <[email protected]>
@tomodachi94
Copy link
Contributor Author

tomodachi94 commented Dec 8, 2022


❯ awesome-lint 'https://github.com/tomodachi94/awesome-computercraft'

✖ Linting



  README.md:9:1

  ✖    1:1    Invalid URL: ./CONTRIBUTING.md                                remark-lint:double-link

  ✖    9:1    Don’t use emphasis to introduce a section, use a heading      remark-lint:no-emphasis-as-heading

  ✖  184:137  List item link and description must be separated with a dash  remark-lint:awesome-list-item

  ✖  200:4    Should not repeat "~"                                         remark-lint:no-repeat-punctuation

  ✖  200:116  Should not repeat "~"                                         remark-lint:no-repeat-punctuation



  5 errors

https://github.com/sindresorhus/awesome-lint

The link at the top to the contributing guidelines is valid, I'm not sure why the linter is complaining.

I am not using emphasis to introduce a section, I am using emphasis... to give emphasis.

The no-repeat-punctuation portion will be solved when I remove the legacy documentation item. The no-repeat-punctuation portion has been fixed by removing the legacy documentation.

I'm not sure what to do with linking a multi-part series like this:

Lyqyd's *Computer Basics* series ([I](https://linktopart.1), [II](https://linktopart.2), [III](https://linktopart.3)) -  *snip*

cc @sindresorhus

(Edit: I ran the linter a few weeks ago and fixed a lot of issues.)

tomodachi94 added a commit to tomodachi94/awesome-computercraft that referenced this pull request Dec 8, 2022
@tomodachi94
Copy link
Contributor Author

CC's original wiki - Contains some useful legacy information. Considered deprecated by modern standards.

This should be removed.

I have just removed it.

@tomodachi94
Copy link
Contributor Author

tomodachi94 commented Jan 29, 2023

@sindresorhus I believe I've satisfied all of the requirements, could you re-review this PR?

@sindresorhus
Copy link
Owner

The linting is stil failing

@tomodachi94
Copy link
Contributor Author

tomodachi94 commented Feb 2, 2023

The linting is stil failing

@sindresorhus I fixed some things, the linter should pass. Also, now there's a GitHub Actions check for awesome-lint if that is more convenient for you.

Repository owner deleted a comment from Superlegend717 Feb 3, 2023
Repository owner deleted a comment from tomodachi94 Feb 3, 2023
@sindresorhus sindresorhus merged commit 8aa3455 into sindresorhus:main Feb 3, 2023
@sindresorhus
Copy link
Owner

Tweet: https://twitter.com/awesome__re/status/1621512042363617284

alex-semenyuk pushed a commit to alex-semenyuk/awesome that referenced this pull request Feb 19, 2023
Co-authored-by: Sindre Sorhus <[email protected]>

Update desription
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants