Add support for PlanPro 1.10 #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arneboockmeyer
changed the title
|
@lpirl Could you just review? I would do the merging on my own. |
lpirl
reviewed
Dec 18, 2024
There was a problem hiding this comment.
putting the two examples/tests in two functions would remove the need for the comments and would avoid variable reuse, but this is just a nit pick
lpirl
reviewed
Dec 18, 2024
There was a problem hiding this comment.
variable not required, could return respective reader right away, but no objection to current code
|
Very good, thank you. There is nothing I veto. Feel free to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.