ci: update ci to supported node.js 18 - 23 versions #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 12, 2024
|
Are you able to consider this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
GitHub Action CI workflows are using versions of Node.js which cause failures. The workflows are also missing other Node.js versions which belong to the set of currently supported Node.js versions, 18 - 23.
v10.24.1GitHub Action versions are not using
node20compatible version, which is currently the only valid value.npm installcommands are using outdated options.Changes
For the following workflows:
then:
Modify each workflow to use the complete set of supported Node.js versions
18.x,20.x,22.xand23.x. .github/workflows/lint.yml is modified to use only the Active LTS version22.x.Update the usage of GitHub's own actions workflows to supported versions:
Update the usage of GitHub action codecov/codecov-action to a supported version:
Remove special handling in .github/workflows/test-windows.yml for Node.js version dependency
Remove the job names
name: AVA & TSD & Benchmark & Codecovsince GitHub is unable to display this text untruncated, and the Node.js version is not visible in the summary. For consistency, also remove thelintjob textname: XO & Prettieras well.Merge the
npm installprodanddevsteps due to outdated options no longer available on Node.js >= 16.Impact
Note that this PR only updates CI. It does not update the
enginesfield in package.json which is currently set to"node": ">=0.10"It does not cause any (breaking) change to the published npm package pidtree and it does not require a new release of the package.
The PR is a prerequisite for any other PRs: allowing them to be checked using CI with an expectation that CI workflows are successful.