Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix spell textures in TWW #109

Merged
merged 3 commits into from
Jun 6, 2024
Merged

fix spell textures in TWW #109

merged 3 commits into from
Jun 6, 2024

Conversation

ntowle
Copy link
Contributor

@ntowle ntowle commented Jun 6, 2024

No description provided.

@silverwind
Copy link
Owner

Hmm, is this GetSpellTexture is available in Classic/SoM clients?

@ntowle
Copy link
Contributor Author

ntowle commented Jun 6, 2024

C_Spell.GetSpellTexture is available in TWW, GetSpellTexture is available in Era/Cata/Dragonflight.

@silverwind
Copy link
Owner

Ah i overlooked that you are aliasing the function. Could you move that inline please into a if C_Spell and C_Spell.GetSpellTexture then ... block? I find that more readable.

@silverwind silverwind merged commit 1c2bbe0 into silverwind:master Jun 6, 2024
1 check passed
@silverwind
Copy link
Owner

Thanks, I will give this a test later before releasing.

@ntowle ntowle deleted the getspelltexure branch June 6, 2024 23:21
silverwind added a commit that referenced this pull request Jun 16, 2024
@silverwind
11.0.0
52ea8e8 
* use single toc format (silverwind)
* fix spell textures in TWW (#109) (Nick Towle)
* Show areaPoiID and vignetteID on world map pins (#76) (David Lynch)
* exclude duplicate version in changelog (silverwind)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ntowle @silverwind