Skip to content

Commit

Permalink
workflows bugfix workaround for FetchContent
Browse files Browse the repository at this point in the history
Temporary workaround until the FetchContent UPDATE_DISCONNECTED bugs
will be fixed.

See: https://discourse.cmake.org/t/fetchcontent-declare-update-disconnected-and-vcpkg/11312
  • Loading branch information
silverqx committed Jul 26, 2024
1 parent 92a6975 commit c2a8a90
Show file tree
Hide file tree
Showing 4 changed files with 34 additions and 16 deletions.
9 changes: 6 additions & 3 deletions .github/workflows/vcpkg-linux-drivers.yml
Original file line number Diff line number Diff line change
Expand Up @@ -467,10 +467,13 @@ jobs:
# Temporary workaround until the FetchContent UPDATE_DISCONNECTED bugs will be fixed
# See: https://discourse.cmake.org/t/fetchcontent-declare-update-disconnected-and-vcpkg/11312
- name: HelloWorld remove build and install trees (FetchContent method)
working-directory: ${{ env.RUNNER_WORKSPACE }}
working-directory: ${{ runner.workspace }}
run: >-
rm --force --recursive ./HelloWorld-builds-cmake/build-TinyDrivers-fetchcontent-gcc-*
rm --force --recursive ./HelloWorld-TinyDrivers-FetchContent-Install
rm --force --recursive
./HelloWorld-builds-cmake/build-TinyDrivers-fetchcontent-gcc-${{ matrix.build-type.key }}
rm --force --recursive
./HelloWorld-TinyDrivers-FetchContent-Install/${{ matrix.build-type.name }}
# CMAKE_DISABLE_PRECOMPILE_HEADERS=OFF is correct (I want to use PCH here)
- name: HelloWorld-TinyDrivers cmake configure (${{ env.HelloWorldFetchContentBuildName }})
Expand Down
9 changes: 6 additions & 3 deletions .github/workflows/vcpkg-linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -419,10 +419,13 @@ jobs:
# Temporary workaround until the FetchContent UPDATE_DISCONNECTED bugs will be fixed
# See: https://discourse.cmake.org/t/fetchcontent-declare-update-disconnected-and-vcpkg/11312
- name: HelloWorld remove build and install trees (FetchContent method)
working-directory: ${{ env.RUNNER_WORKSPACE }}
working-directory: ${{ runner.workspace }}
run: >-
rm --force --recursive ./HelloWorld-builds-cmake/build-fetchcontent-gcc-*
rm --force --recursive ./HelloWorld-FetchContent-Install
rm --force --recursive
./HelloWorld-builds-cmake/build-fetchcontent-gcc-${{ matrix.build-type.key }}
rm --force --recursive
./HelloWorld-FetchContent-Install/${{ matrix.build-type.name }}
# CMAKE_DISABLE_PRECOMPILE_HEADERS=OFF is correct (I want to use PCH here)
- name: HelloWorld cmake configure (${{ env.HelloWorldFetchContentBuildName }})
Expand Down
16 changes: 11 additions & 5 deletions .github/workflows/vcpkg-windows-drivers.yml
Original file line number Diff line number Diff line change
Expand Up @@ -479,11 +479,17 @@ jobs:
# Temporary workaround until the FetchContent UPDATE_DISCONNECTED bugs will be fixed
# See: https://discourse.cmake.org/t/fetchcontent-declare-update-disconnected-and-vcpkg/11312
- name: HelloWorld remove build and install trees (FetchContent method)
working-directory: ${{ env.RUNNER_WORKSPACE }}
run: >-
Remove-Item -Force -Recurse -Path
./HelloWorld-builds-cmake/Drivers-fetchcontent-msvc-*,
./HelloWorld-TinyDrivers-FetchContent-Install
working-directory: ${{ runner.workspace }}
run: |
if (Test-Path ./HelloWorld-builds-cmake/Drivers-fetchcontent-msvc-${{ matrix.build-type.key }}) {
Remove-Item -Force -Recurse -Path `
./HelloWorld-builds-cmake/Drivers-fetchcontent-msvc-${{ matrix.build-type.key }}
}
if (Test-Path ./HelloWorld-TinyDrivers-FetchContent-Install/${{ matrix.build-type.name }}) {
Remove-Item -Force -Recurse -Path `
./HelloWorld-TinyDrivers-FetchContent-Install/${{ matrix.build-type.name }}
}
# CMAKE_DISABLE_PRECOMPILE_HEADERS=ON is correct (Windows ccache doesn't work well with PCH)
- name: HelloWorld-TinyDrivers cmake configure (${{ env.HelloWorldFetchContentBuildName }})
Expand Down
16 changes: 11 additions & 5 deletions .github/workflows/vcpkg-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -426,11 +426,17 @@ jobs:
# Temporary workaround until the FetchContent UPDATE_DISCONNECTED bugs will be fixed
# See: https://discourse.cmake.org/t/fetchcontent-declare-update-disconnected-and-vcpkg/11312
- name: HelloWorld remove build and install trees (FetchContent method)
working-directory: ${{ env.RUNNER_WORKSPACE }}
run: >-
Remove-Item -Force -Recurse -Path
./HelloWorld-builds-cmake/build-fetchcontent-msvc-*,
./HelloWorld-FetchContent-Install
working-directory: ${{ runner.workspace }}
run: |
if (Test-Path ./HelloWorld-builds-cmake/build-fetchcontent-msvc-${{ matrix.build-type.key }}) {
Remove-Item -Force -Recurse -Path `
./HelloWorld-builds-cmake/build-fetchcontent-msvc-${{ matrix.build-type.key }}
}
if (Test-Path ./HelloWorld-FetchContent-Install/${{ matrix.build-type.name }}) {
Remove-Item -Force -Recurse -Path `
./HelloWorld-FetchContent-Install/${{ matrix.build-type.name }}
}
# CMAKE_DISABLE_PRECOMPILE_HEADERS=ON is correct (Windows ccache doesn't work well with PCH)
- name: HelloWorld cmake configure (${{ env.HelloWorldFetchContentBuildName }})
Expand Down

0 comments on commit c2a8a90

Please sign in to comment.