support generics #171
Merged
support generics #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firesphere
reviewed
Nov 15, 2024
| @@ -155,7 +157,11 @@ protected function generateTagsForDataLists($fields, $listType = DataList::class | |||
| $listName = $this->getAnnotationClassName($listType); | |||
| $dataObjectName = $this->getAnnotationClassName($dataObjectName); | |||
|
|
|||
| $tagString = "{$listName}|{$dataObjectName}[] {$fieldName}()"; | |||
| if ($useGenerics) { | |||
There was a problem hiding this comment.
I would remove the else bit, and leave line 158 intact. That way, it's set, then overridden if the else is true.
Just a personal preference of avoiding elses where possible
There was a problem hiding this comment.
agreed i also prefer it that way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
helps with #170
this allows to get \SilverStripe\ORM\DataList<\MyObject> MyObjects() notation and is, currently, only enabled if you want it in the yml config to avoid side effects on older projects