+semver:major Changed to target .Net Framework 4.6.2 instead of 4.6.1

[tombogle]

This change is 

[github-actions]

LibPalaso Tests

    37 files  ±0      37 suites  ±0   9m 47s ⏱️ +14s
 4 828 tests ±0   4 597 ✅ ±0  231 💤 ±0  0 ❌ ±0 
11 193 runs  ±0  10 662 ✅ ±0  531 💤 ±0  0 ❌ ±0 

Results for commit 3cbc821. ± Comparison against base commit 17401d1.

♻️ This comment has been updated with latest results.

[andrew-polk]

Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @hahn-kev, @josephmyers, and @tombogle)

---

CHANGELOG.md line 47 at r1 (raw file):

### Changed

- Changed to target .Net Framework 4.6.2 instead of 4.6.1

Should there be something here to make it more obvious that this is a breaking change?

[tombogle]

CHANGELOG.md line 47 at r1 (raw file):

Previously, andrew-polk wrote…

Should there be something here to make it more obvious that this is a breaking change?

I looked down through the changelog file to see if/how we had handled other similar things (specifically to know whether something should go in square brackets at the start of the line). I'm not quite sure there has been anything entirely analogous since we first started creating nuget packages. Of course, the semver: major itself makes it clear in the git history and that will trigger a new major version number. On nuget.org, it's very clear which frameworks are targeted by any package, and I'm pretty sure the package manager in VS will holler loudly if someone tries to upgrade a package to a version that is incompatible with their project's target framework. So I believe we're covered. That said, if you think it's warranted, I could make it something like:

Code snippet:

- **WARNING** **WARNING** **WARNING!!!**
- **BREAKING CHANGE:** Changed to target .Net Framework 4.6.2 instead of 4.6.1
- **YOU HAVE BEEN WARNED!!!**

[andrew-polk]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @hahn-kev, @josephmyers, and @tombogle)

---

CHANGELOG.md line 47 at r1 (raw file):
: )

Probably

BREAKING CHANGE: Changed to target .Net Framework 4.6.2 instead of 4.6.1

is sufficient.

Or maybe better would be to have a

Breaking Changes

section before the

Added

section

[imnasnainaec]

net461 still appears in TestApps/SIL.Windows.Forms.TestApp/environ and TestApps/SIL.Windows.Forms.TestApp/README.md.

There's also sku=".NETFramework,Version=v4.6.1" in 16 files.

[tombogle]

net461 still appears in TestApps/SIL.Windows.Forms.TestApp/environ and TestApps/SIL.Windows.Forms.TestApp/README.md.

There's also sku=".NETFramework,Version=v4.6.1" in 16 files.

Thanks for catching those things. I knew there had to be more to it! If I understand correctly, with this change we are officially abandoning support for mono (specifically mono-sil). If so, then I believe the correct thing is to delete the environ file altogether.

[tombogle]

CHANGELOG.md line 47 at r1 (raw file):

Previously, andrew-polk wrote…

: )

Probably

BREAKING CHANGE: Changed to target .Net Framework 4.6.2 instead of 4.6.1

is sufficient.

Or maybe better would be to have a

Breaking Changes

section before the

Added

section

The sections follow the https://keepachangelog.com/ guidelines. The vast majority of the things listed in the Changed section are breaking changes. After some reflection, I think it probably makes sense to include this in the Removed section as well.

[andrew-polk]

Reviewed 18 of 18 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @hahn-kev and @josephmyers)