Fix math primes and asterisk #2174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Omikhleia
added
bug
Omikhleia
force-pushed
the
fix-math-primes-asterisk
branch
2 times, most recently
from
ab4672e to
61e3093
Compare
Omikhleia
commented
Nov 19, 2024
alerque
force-pushed
the
fix-math-primes-asterisk
branch
from
61e3093 to
e83ac92
Compare
|
Rebased on master to catch the CI related fixes I made there (after having broken it of course). |
…imes and asterisk
Omikhleia
force-pushed
the
fix-math-primes-asterisk
branch
from
e83ac92 to
f83ccc5
Compare
|
Rebased with a better implementation, and extra tests. I also slightly updated the in-package documentation on the math feature (I wasn't totally correct on the STIX Two mention) |
Omikhleia
commented
Nov 21, 2024
Omikhleia
force-pushed
the
fix-math-primes-asterisk
branch
2 times, most recently
from
66ea19a to
bd428ea
Compare
|
And rebased with a more standard-approach on the ssty feature. |
Omikhleia
force-pushed
the
fix-math-primes-asterisk
branch
from
bd428ea to
b2ca8b4
Compare
alerque
approved these changes
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2173