Add active hook system to settings #1983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
alerque
force-pushed
the
setting-hooks
branch
from
4c9f6d5 to
8cc06a6
Compare
alerque
force-pushed
the
setting-hooks
branch
from
8cc06a6 to
06d3f7a
Compare
alerque
force-pushed
the
setting-hooks
branch
from
06d3f7a to
a1c4952
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c.f. #1963 (comment)
After discussion on the above issue I looked and found 3 different places I had monkey-patched a callback system into settings for various reasons. Looking over my own past hacks I think this feature would have made all of them better.