Store instantiated packages not just module source #1979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alerque
force-pushed
the
once-upon-a-package
branch
from
ccde110 to
e45cb9a
Compare
alerque
force-pushed
the
once-upon-a-package
branch
from
e45cb9a to
70db203
Compare
This re-runs the _init() function to potentially force a reload or change options, but it avoids re-instantiating a new instance from the package class.
alerque
force-pushed
the
once-upon-a-package
branch
from
70db203 to
3c3fada
Compare
|
I'm going ahead with merging this because I'm sure it's better than what is in develop now. I'm not sure it's all perfect yet or whether it addresses others concerns, hence the related issue is being left open for further discussion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1974, probably more things to address yet but this is the big one.