Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update deps to point to relevant alloy branches #27

Closed
wants to merge 11 commits into from

Conversation

eserilev
Copy link
Contributor

@eserilev eserilev commented Jul 10, 2024

This crate needs to reference the other downstream alloy branches for Encode/Decode/TreeHash derive macros for the relevant ssz types to work in Lighthouse

morph-dev and others added 6 commits July 3, 2024 18:52
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.08%. Comparing base (e22576e) to head (8338970).
Report is 8 commits behind head on alloy.

Additional details and impacted files
@@            Coverage Diff             @@
##            alloy      #27      +/-   ##
==========================================
+ Coverage   60.98%   61.08%   +0.10%     
==========================================
  Files           9        9              
  Lines         487      496       +9     
==========================================
+ Hits          297      303       +6     
- Misses        190      193       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelsproul
Copy link
Member

I was hoping this wouldn't be necessary if we use [patch]s in the Lighthouse Cargo.toml. It would be nice to avoid, because it means we don't need to update all the alloy branches and they can be in a ready-to-merge state

@michaelsproul
Copy link
Member

closing in favour of using released versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants