-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move BitList
and BitVector
to ethereum_ssz
#25
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
==========================================
- Coverage 80.16% 77.48% -2.69%
==========================================
Files 11 12 +1
Lines 489 715 +226
==========================================
+ Hits 392 554 +162
- Misses 97 161 +64 ☔ View full report in Codecov by Sentry. |
mod decode; | ||
mod encode; | ||
pub mod legacy; | ||
mod union_selector; | ||
|
||
#[doc(hidden)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've hidden these types in the docs which I believe means the current documentation should remain unchanged.
Since we are re-exporting the Bitfield types in ssz_types
the documentation for them will still exist in that crate. Like it does now.
There might be an argument for moving the documentation across (or duplicating it), but I'm loosely in favour of this approach for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The diff from ssz_types
is minimal now that resize
has been added.
In preparation of EIP-7495, it will be very useful to have a fully functional BitVector implementation in this crate, so we don't need to depend on
ssz_types
, avoiding a circular dependency.This moves the two types previously defined in
https://github.com/sigp/ssz_types
toethereum_ssz/ssz
. This will allow us to utilize it withinssz_derive
.This PR should be paired with an equivalent PR in
ssz_types
which removes the types and instead re-exports them fromethereum_ssz
. It should also be paired with a PR intree_hash
which implementsTreeHash
forBitVector
andBitList
.Related PRs: