Merging incremental-checkpoint-feature branch to master #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…feature Incremental checkpoint feature
…to incremental-checkpoint-feature
…and improve state management
…se case that was failing
…t-feature # Conflicts: # docs/api/latest.md
tishan89
requested changes
May 31, 2018
| @@ -0,0 +1,40 @@ | |||
| /* | |||
| * Copyright (c) 2016, WSO2 Inc. (http://www.wso2.org) All Rights Reserved. | |||
There was a problem hiding this comment.
Fixed in 889e5cb
|
|
||
| SiddhiManager siddhiManager = new SiddhiManager(); | ||
|
|
||
| // PersistenceStore persistenceStore = new org.wso2.siddhi.core.util.persistence.FileSystemPersistenceStore(); |
There was a problem hiding this comment.
Remove commented out code
There was a problem hiding this comment.
Fixed in 889e5cb
| * The class which encloses multiple snapshot states. | ||
| */ | ||
| public class SnapshotStateList implements Serializable { | ||
| private TreeMap<Long, SnapshotState> snapshotStates = new TreeMap<>(); |
There was a problem hiding this comment.
Don't we need a serialVersionUUID?
There was a problem hiding this comment.
Looks like it's not needed here as the find bugs plugin did not complain on this.
tishan89
approved these changes
May 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Adding incremental checkpointing API to Siddhi
Goals
Introducing incremental checkpointing functionality to state persistence. Please refer #820
Release note
Introducing incremental checkpointing functionality to state persistence
Related PRs
#695