Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate new deployments #1934

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

oddgrd
Copy link
Contributor

@oddgrd oddgrd commented Dec 20, 2024

Description of change

As of the 1st of January 2025, making new deployments on the shuttle.rs platform has been deprecated, and users will be directed to upgrade to the shuttle.dev platform.

How has this been tested? (if applicable)

Will test in staging.

@oddgrd oddgrd requested a review from jonaro00 December 20, 2024 09:02
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR updates the deprecation messaging for the shuttle.rs platform, focusing on two key changes:

  • Modified gateway/src/service.rs to update project creation deprecation message from "is deprecated" to "has been deprecated" as of December 19th, 2024
  • Added deprecation handling in gateway/src/api/latest.rs to block new deployments with a notice effective January 1st, 2024
  • Maintains existing functionality while directing users to migrate to shuttle.dev platform

2 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile

gateway/src/service.rs Show resolved Hide resolved
gateway/src/api/latest.rs Outdated Show resolved Hide resolved
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

This PR continues the deprecation of shuttle.rs by removing PostHog analytics integration and updating related infrastructure.

  • Removed async-posthog dependency and all PostHog client code from gateway/Cargo.toml and related files
  • Simplified override_create_service in gateway/src/api/latest.rs by removing unused parameters and state
  • Removed PostHog client initialization and usage from gateway/src/main.rs start function

The changes focus on cleaning up analytics tracking while maintaining the core deprecation functionality previously implemented.

3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants