Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Critical dependency: the request of a dependency is an expression warnings #3330

Merged
merged 6 commits into from
Oct 2, 2024

Conversation

dimaMachina
Copy link
Collaborator

@dimaMachina dimaMachina commented Sep 30, 2024

fixes #3322

Copy link

changeset-bot bot commented Sep 30, 2024

🦋 Changeset detected

Latest commit: a0267ca

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
nextra Patch
nextra-theme-blog Patch
nextra-theme-docs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Sep 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextra-theme-docs-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 6:41pm
nextra-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 6:41pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
nextra ⬜️ Ignored (Inspect) Visit Preview Oct 2, 2024 6:41pm

Copy link
Contributor

github-actions bot commented Sep 30, 2024

📦 Next.js Bundle Analysis for swr-site

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link
Contributor

github-actions bot commented Sep 30, 2024

📦 Next.js Bundle Analysis for docs

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 174.91 KB (-2 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Sixteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 51.51 KB (-1 B) 226.42 KB
/docs 8.42 KB (🟢 1 B) 183.33 KB
/docs/blog-theme 11.25 KB (🟢 2 B) 186.16 KB
/docs/blog-theme/start 14.11 KB (1 B) 189.02 KB
/docs/docs-theme 11.31 KB (1 B) 186.22 KB
/docs/docs-theme/built-ins 11.32 KB (-1 B) 186.23 KB
/docs/guide/advanced/customize-the-cascade-layers 7.66 KB (🟢 -1 B) 182.57 KB
/docs/guide/advanced/playground 12.51 KB (🟢 2 B) 187.42 KB
/docs/guide/advanced/remote 7.02 KB (🟢 1 B) 181.93 KB
/docs/guide/advanced/table 13.97 KB (-1 B) 188.88 KB
/docs/guide/built-ins 11.38 KB (🟢 2 B) 186.29 KB
/docs/guide/i18n 8.31 KB (🟢 -1 B) 183.21 KB
/docs/guide/image 8.37 KB (🟢 -2 B) 183.28 KB
/docs/guide/link 6.98 KB (🟢 1 B) 181.89 KB
/docs/guide/markdown 12.75 KB (-1 B) 187.66 KB
/showcase 14.08 KB (1 B) 188.98 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by undefined% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@dimaMachina dimaMachina changed the title patch @typescript/vfs to remove Critical dependency: the request of a dependency is an expression warnings remove Critical dependency: the request of a dependency is an expression warnings Oct 2, 2024
@LoicPoullain
Copy link

Still getting the issue after the release. 🤷 Using v3.0.4.

@dimaMachina
Copy link
Collaborator Author

Please create new issue with reproduction

Repository owner locked as resolved and limited conversation to collaborators Oct 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Watchpack Error (initial scan): Error: ENOTDIR: not a directory in v3
2 participants