Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating fixtures for
CreditTransaction
it callsself.rule.display()
and fail withNotImplementedError
. I'm using a rule, that has the method implemented, but still failing.https://github.com/shoutit/shoutit-api/compare/test_misc?expand=1#diff-78647ee16003f16aa9c144f2b16f1cb2R26
Monkey patched
ShoutitJSONSerializer
causesRuntimeError
due to max recursion depth.https://github.com/shoutit/shoutit-api/compare/test_misc?expand=1#diff-d2e3a0c2b2bd55e14fc17b4b975f920cR53
API docs example does not work for all misc FB endpoints. Also BTW, the GET methods describe it expecting POST data and so on. So I assume docs are wrong, kind of?
https://github.com/shoutit/shoutit-api/compare/test_misc?expand=1#diff-d2e3a0c2b2bd55e14fc17b4b975f920cR75
FYI: The endpoint switches between "New York" and "Jersey City" for the coordinates in the docs even though it's clearly in Jersey. I chose "Berlin" for the tests to make sure they pass.
https://github.com/shoutit/shoutit-api/compare/test_misc?expand=1#diff-d2e3a0c2b2bd55e14fc17b4b975f920cR164
Here I tried to test for the results in the response. I've limited most of it to less than the default page size, so that even the randomisation would not take effect and drop some off the page.
Still seems as if it was failing at random places, sometimes containing the expected results and if I wait a minute or two to repeat the tests, they suddenly fail at the same point.
I experienced some issues with the cache being on while running the tests and would guess, that it might have to do with that.
Testing with an actual active cache defies the sense of testing code, because most of the time, you will not be testing the code, but only the cached response.
Do you have mechanisms in place to disable cache in tests completely? I haven't seen anything like it (i.e. in test settings or so).
https://github.com/shoutit/shoutit-api/compare/test_misc?expand=1#diff-d2e3a0c2b2bd55e14fc17b4b975f920cR282