Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop macos-12 support #2032

Merged
merged 2 commits into from
Dec 18, 2024
Merged

drop macos-12 support #2032

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d4944b
drop macos-12 support
shogo82148 Dec 17, 2024
cc43081
update build tools
shogo82148-slim[bot] Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/darwin-x64.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
matrix: ${{ steps.set-matrix.outputs.matrix }}

sanity-check:
runs-on: macos-12
runs-on: macos-13
permissions:
contents: read
steps:
Expand All @@ -65,7 +65,7 @@ jobs:
PERL5LIB: ${{ github.workspace }}/scripts/lib

build:
runs-on: macos-12
runs-on: macos-13
needs:
- sanity-check
- list
Expand Down Expand Up @@ -124,7 +124,7 @@ jobs:
subject-path: ${{ runner.temp }}/*.tar.zstd

build-multi-thread:
runs-on: macos-12
runs-on: macos-13
needs:
- sanity-check
- list
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,6 @@ jobs:
- macos-15
- macos-14
- macos-13
- macos-12
multi-thread:
- false
- true
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update-build-tools.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
path: scripts/linux/cpanfile.snapshot

darwin:
runs-on: macos-12
runs-on: macos-13
steps:
- name: setup host perl
run: perl -MConfig -E 'say "$Config{bin}"' >> "$GITHUB_PATH"
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ The action works for [GitHub-hosted runners](https://docs.github.com/en/actions/
| Operating System | Supported Versions |
| ---------------- | ---------------------------------------------- |
| Linux | `ubuntu-20.04`, `ubuntu-22.04`, `ubuntu-24.04` |
| macOS | `macos-12`, `macos-13`, `macos-14` |
| macOS | `macos-13`, `macos-14`, `macos-15` |
| Windows | `windows-2019`, `windows-2022` |

[Self-hosted runners](https://docs.github.com/en/actions/hosting-your-own-runners) are not supported.
Expand Down
14 changes: 7 additions & 7 deletions scripts/common/cpanfile.snapshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@ DISTRIBUTIONS
Canary::Stability 2013
requirements:
ExtUtils::MakeMaker 0
Cpanel-JSON-XS-4.38
pathname: R/RU/RURBAN/Cpanel-JSON-XS-4.38.tar.gz
Cpanel-JSON-XS-4.39
pathname: R/RU/RURBAN/Cpanel-JSON-XS-4.39.tar.gz
provides:
Cpanel::JSON::XS 4.38
Cpanel::JSON::XS 4.39
Cpanel::JSON::XS::Type undef
requirements:
Carp 0
Expand Down Expand Up @@ -53,7 +53,7 @@ DISTRIBUTIONS
JSON::MaybeXS 1.004008
requirements:
Carp 0
Cpanel::JSON::XS 2.3310
Cpanel::JSON::XS 4.38
ExtUtils::MakeMaker 0
JSON::PP 2.27300
Scalar::Util 0
Expand Down Expand Up @@ -146,10 +146,10 @@ DISTRIBUTIONS
perl 5.008001
strict 0
warnings 0
YAML-Tiny-1.74
pathname: E/ET/ETHER/YAML-Tiny-1.74.tar.gz
YAML-Tiny-1.76
pathname: E/ET/ETHER/YAML-Tiny-1.76.tar.gz
provides:
YAML::Tiny 1.74
YAML::Tiny 1.76
Comment on lines +149 to +152
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Based on the search results, I can now generate the final response:

YAML::Tiny version update requires build script updates

The version bump from 1.74 to 1.76 in cpanfile.snapshot needs corresponding updates in the build scripts. Found inconsistencies in:

  • scripts/linux/build.pl: Still references version 1.74
  • scripts/windows/build.pl: Still references version 1.74
  • scripts/darwin/build.pl: Still references version 1.74
🔗 Analysis chain

Verify YAML-Tiny version update compatibility

The update from 1.74 to 1.76 appears to be a minor version bump. Let's verify the changes and compatibility.

Let me try another approach to verify the version compatibility.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check changelog and compatibility of YAML-Tiny 1.76

# Fetch the latest version information and changes
curl -s https://fastapi.metacpan.org/v1/release/ETHER/YAML-Tiny-1.76 | jq -r '.changes'

# Check for any reported issues with macOS
gh search issues "YAML-Tiny 1.76 macos" --repo shogo82148/actions-setup-perl

Length of output: 171

Script:

#!/bin/bash
# Search for YAML::Tiny usage in the codebase
rg "YAML::Tiny" -B2 -A2

# Look for any test files that might use YAML::Tiny
fd -e t$ -e pl$ --exec grep -l "YAML::Tiny" {}

# Check if there are any specific YAML::Tiny version requirements in other Perl module files
fd cpanfile$ | xargs cat

Length of output: 6263

requirements:
B 0
Carp 0
Expand Down
Loading