Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FontAwesome for ALL! the icons #58

Merged
merged 1 commit into from
Aug 13, 2014

Conversation

nathancarnes
Copy link
Contributor

Since FontAwesome is getting loaded up anyway, we can ditch a few images and clean up a bunch of CSS by implementing it throughout the site.

At some point down the road it would be good to update FontAwesome to a newer version, but it probably makes sense to tackle that at the same time as upgrading Bootstrap.

@jasonrclark
Copy link
Member

I really like the updated look with that! I'm in favor of a merge. @PragTob @wasnotrice?

A few before and after's for anyone who doesn't want to pull it down to run themselves.

Bottom of homepage
Before:
image

After:
image

Downloads
Before:
image

After:
image

@nathancarnes
Copy link
Contributor Author

@jasonrclark thanks! I should have added the before/afters.

Depending on the timing of #52, I'd also be willing to tackle upgrading Bootstrap + FontAwesome, which should also resolve #13.

@wasnotrice
Copy link
Member

Love it!

@PragTob
Copy link
Member

PragTob commented Aug 13, 2014

Font Awesome is awesome, totally pro on this one! So yeah! 👍 :-D

@wpp
Copy link
Contributor

wpp commented Aug 13, 2014

Looking good!

@jasonrclark
Copy link
Member

💥

jasonrclark added a commit that referenced this pull request Aug 13, 2014
Use FontAwesome for ALL! the icons
@jasonrclark jasonrclark merged commit a93b0e1 into shoes:gh-pages Aug 13, 2014
@jasonrclark
Copy link
Member

Thanks again @nathancarnes for that! If you're interested in upgrading Bootstrap + FontAwesome, it sounds over on #52 like that probably isn't moving quickly. @wpp expressed some interest over there too, so you might coordinate with him about any changes so we don't get any duplicate/overlapping work.

Appreciate everyone pitching in to improve the site so much! ❤️

@nathancarnes
Copy link
Contributor Author

@jasonrclark I'll check in over there and see how I can make myself useful. ❤️

@PragTob
Copy link
Member

PragTob commented Aug 14, 2014

Thanks @nathancarnes ! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants