Support encrypted connections to MySQL/Maria and Postgres #2314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2314 +/- ##
==========================================
Coverage 93.71% 93.71%
- Complexity 1682 1683 +1
==========================================
Files 276 276
Lines 5840 5841 +1
==========================================
+ Hits 5473 5474 +1
Misses 367 367 ☔ View full report in Codecov by Sentry. |
acelaya
force-pushed
the
feature/database-ssl
branch
from
2b50888 to
6c0ca3d
Compare
acelaya
force-pushed
the
feature/database-ssl
branch
from
6c0ca3d to
4e7d090
Compare
acelaya
commented
Dec 20, 2024
| @@ -18,7 +18,7 @@ | |||
| "ext-json": "*", | |||
| "ext-mbstring": "*", | |||
| "ext-pdo": "*", | |||
| "akrabat/ip-address-middleware": "^2.4", | |||
| "akrabat/ip-address-middleware": "^2.5", | |||
There was a problem hiding this comment.
Unrelated to changes here, but the lack of lockfile makes this get updated anyway, and since it implies a change in code, I have enforced the newer version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2206
Add a new
DB_USE_ENCRYPTIONconfig option to dynamically update the database configuration so that it requires encrypted connections to MySQL/MariaBD and Postgres databases.In theory, this was already supported for Microsoft SQL servers, but has been never verified.