Be less restrictive on what characters are disallowed in custom slugs #2310
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2156
Reduce the strictness on what characters can be used in custom slugs.
At one point, a bug was reported that using
?
would create invalid URLs, as the server would then detect anything after the question mark as part of the query string, and never match the short URL.In order to prevent this, Shlink started to forbid the use of URL-reserved characters in custom slugs, but that broke the experience for users which were using some of those characters.
This PR reduces a bit the strictness, by still forbidding the use of URL-reserved characters that are used to split parts of a URI (gen-delimiters), but allowing other reserved characters (sub-delimiters) like
+
or&
.