Support filtering orphan visits by type in VisitRepository #1995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelaya
force-pushed
the
feature/orphan-visits-filter
branch
from
2e41485 to
46acf4d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1995 +/- ##
=============================================
+ Coverage 96.90% 96.93% +0.02%
- Complexity 1346 1355 +9
=============================================
Files 247 250 +3
Lines 4660 4696 +36
=============================================
+ Hits 4516 4552 +36
Misses 144 144 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1979
Shlink-web-client has supported filtering orphan visits by type for some time, but this was always done client-side.
This PR adds the ability to filter orphan visits lists by
type, both via REST API and CLI.