Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when importing short URLs while using Postgres #1948

Merged
merged 1 commit into from
Dec 16, 2023

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Dec 16, 2023

Closes #1947

Avoid trying to query DB with an empty ID, as that fails in Postgres.

Copy link

codecov bot commented Dec 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3a43aa4) 96.90% compared to head (1b14bb0) 96.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #1948   +/-   ##
==========================================
  Coverage      96.90%   96.90%           
- Complexity      1340     1341    +1     
==========================================
  Files            247      247           
  Lines           4647     4650    +3     
==========================================
+ Hits            4503     4506    +3     
  Misses           144      144           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya merged commit 4d28adf into shlinkio:develop Dec 16, 2023
33 checks passed
@acelaya acelaya deleted the feature/fix-postgres-import branch December 16, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot import from CSV to postgresql
1 participant