Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export defines PUBLIC so that headers work properly #250

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Export defines PUBLIC so that headers work properly #250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/dft/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,5 +351,9 @@ set_target_properties(${TARGET_LIBDFT} PROPERTIES

# Install

target_compile_definitions(${TARGET_LIBDFT}
PUBLIC ${COMMON_TARGET_DEFINITIONS}
)

install(FILES ${PROJECT_SOURCE_DIR}/include/sleefdft.h DESTINATION include)
install(TARGETS ${TARGET_LIBDFT} DESTINATION lib)
4 changes: 2 additions & 2 deletions src/libm/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,14 +184,14 @@ set_target_properties(${TARGET_LIBSLEEF} PROPERTIES
)

target_compile_definitions(${TARGET_LIBSLEEF}
PRIVATE DORENAME=1 ${COMMON_TARGET_DEFINITIONS}
PRIVATE DORENAME=1 PUBLIC ${COMMON_TARGET_DEFINITIONS}
)

if(COMPILER_SUPPORTS_FLOAT128)
# TODO: Not supported for LLVM bitcode gen as it has a specific compilation flags
target_sources(${TARGET_LIBSLEEF} PRIVATE sleefqp.c)
target_compile_definitions(${TARGET_LIBSLEEF}
PRIVATE ENABLEFLOAT128=1 ${COMMON_TARGET_DEFINITIONS})
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

COMMON_TARGET_DEFINITIONS was removed from this line because it is already added in the previous target_compile_definitions

PUBLIC ENABLEFLOAT128=1)
endif()

if(COMPILER_SUPPORTS_BUILTIN_MATH)
Expand Down