Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement backend support for tag colors #4362

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: implement backend support for tag colors #4362

wants to merge 2 commits into from

Conversation

haller33
Copy link
Contributor

@haller33 haller33 commented Nov 26, 2024 •
edited
Loading

feat(devices): implement backend support for tag colors

@haller33 haller33 self-assigned this Nov 26, 2024
@haller33 haller33 force-pushed the feat/tag-color-support branch 9 times, most recently from 26d50d8 to 4654758 Compare December 4, 2024 16:46
@haller33 haller33 force-pushed the feat/tag-color-support branch 13 times, most recently from 6bb4533 to 954abfa Compare December 9, 2024 13:20
@haller33 haller33 marked this pull request as ready for review December 9, 2024 13:20
@haller33 haller33 requested a review from a team as a code owner December 9, 2024 13:20
@haller33 haller33 force-pushed the feat/tag-color-support branch from b5e4846 to dc766ed Compare December 10, 2024 15:02
heiytor
heiytor reviewed Dec 10, 2024
View reviewed changes
Copy link
Contributor

@heiytor heiytor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also noticed that some of the newly added Tag methods don’t have tests. Could you implement them?

api/services/utils.go Outdated Show resolved Hide resolved
api/store/mongo/device_tags.go Show resolved Hide resolved
api/store/mongo/tags.go Outdated Show resolved Hide resolved
api/store/mongo/device_tags.go Outdated Show resolved Hide resolved
@haller33 haller33 force-pushed the feat/tag-color-support branch from dc766ed to e5193e7 Compare December 11, 2024 12:47
@haller33 haller33 force-pushed the feat/tag-color-support branch 3 times, most recently from f6b5f3e to f9e95ed Compare December 11, 2024 19:55
@haller33 haller33 force-pushed the feat/tag-color-support branch 6 times, most recently from ac2c3e9 to 0452729 Compare December 18, 2024 12:52
@haller33 haller33 force-pushed the feat/tag-color-support branch from 0452729 to 22d91ea Compare December 18, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heiytor heiytor Awaiting requested review from heiytor

@gustavosbarreto gustavosbarreto Awaiting requested review from gustavosbarreto

Assignees

@haller33 haller33

Labels
area/api do-not-merge go Pull requests that update Go code status/needs-review status/under-testing Tests broadened status/work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haller33 @gustavosbarreto @heiytor