fix(dialyzer): the pattern false can never match the type true (#21) #25
+15
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the fact, that the after compile hook was generated into each module, and used
the modules attributes directly, from dialyzers point of view, all the branches were
based on constant values and there was no way that ever any condition changes.
This is solved by moving the implementation of the
__after_compile__/2
hook into theQue.Worker
module, where it accesses the passed in environment to check the validityof the freshly compiled module.
As a side effect, this also reduces the worker modules sizes slightly, as the
__after_compile__/2
does not have to be compiled into each module anymore, when its sole purpose on runtime
is to only return
nil
!Fix #21