Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic field sorting fixes. #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Basic field sorting fixes. #5

wants to merge 2 commits into from

Conversation

lucashpandolfo
Copy link

Fixes the ability to do some basic field sorting like
(montezuma:search *index* "title:wathever" :sort '("title"))

@lucashpandolfo lucashpandolfo mentioned this pull request Nov 23, 2015
Open
@luismbo
Copy link
Member

luismbo commented Nov 23, 2015

Does it pass the test suite?

Also, bonus points if you add a new test for the functionality you've just fixed. :-)

@lucashpandolfo
Copy link
Author

Well.... no.
Let me see...
I see a couple of errors and skipped tests, but they were broken before :P
Ok. I need some bonus points, so there it is. Some basic tests for this basic functionality.

Also, as I REALLY need some bonus points, #6 fixes the previously broken tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucashpandolfo @luismbo