xkeyboard WIP #100
xkeyboard WIP #100
Conversation
extensions/xkeyboard.lisp
Outdated
| (defun xkb-bell (display &key (device +use-core-kbd+) | ||
| bell-class | ||
| id | ||
| percent |
There was a problem hiding this comment.
I've noticed that in a few places (not all, so this is not consistent) you use tabs. Please detabify sources. You can do that in emacs with M-x whitespace-cleanup in a buffer. If you want to see spaces and tabs visually, there is M-x whitespace-mode.
There was a problem hiding this comment.
I just indented the files and ran whitespace-cleanup on each file.
extensions/xkb-constants.lisp
Outdated
| (defconstant +wrap-into-range+ #x00) | ||
| (defconstant +clamp-into-range+ #x40) | ||
| (defconstant +redirect-into-range+ #x80) | ||
| ;; (defconstant +virtual_modifier_15+ #x80) |
There was a problem hiding this comment.
why these constants are commented out?
There was a problem hiding this comment.
Not sure... I've removed them for now.
|
this also still misses tests and documentation on how to use the extension |
|
bump |
|
I'm so sorry for not following up. I took a quick stab at this last summer, wrote up a blog post (https://github.com/stumpwm/stumpwm/wiki/International-Input-and-XKeyboard-Development) volunteering to coordinate, and completely forgot about this PR. A lot of the style points you mention in your code review are largely due to the fact that I pulled the initial WIP from mikhail filonenko's copy. I will address these in the next few days. As you correctly point out, I don't have any supporting documentation or example code because I haven't worked on this for a while, and haven't developed it to the point where I even know how to write example code. Apologies for presenting a half-baked solution, it may be that we won't merge this now, and instead wait until I have something more mature. Really, I just want something to get the ball rolling so others can pick up and make meaningful contributions instead of re-doing all the research I did into the background of the problem. |
|
Hi, there is interest from McCLIM in having a coordinated effort to finishing this extension. Those who contribute will have some claim to the $500 bounty. At this point there are enough authors involved that the $500 will have to be split somehow. What is the best way for us to coordinate development? I'm happy to lead and coordinate efforts, I'm just not sure what the best way to do it is since I can't accept PRs to my fork of clx. |
This is my code-where-my-mouth is commit demonstrating that I will work on developing xkeyboard. I already talked to @filonenko-mikhail and he gave me permission to port his code to clx, from there I will work on true internationlized input.