feat(Ads): New HLS interstitial DATERANGE attributes for Skip Button #7467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: enhancement
|
Incremental code coverage: 54.67% |
joeyparrish
requested changes
Oct 22, 2024
| if (this.isSkippable_ && this.skipFor_ != null) { | ||
| const position = this.getDuration() - this.getRemainingTime(); | ||
| const maxTime = this.skipOffset_ + this.skipFor_; | ||
| return position < maxTime; |
There was a problem hiding this comment.
So, if you don't skip fast enough, you lose the chance? That seems backwards to how most skippable ads work, in my experience.
There was a problem hiding this comment.
Yes, it is a new feature that is only activated for HLS interstitials, and it is configurable. If you configure X-ENABLE-SKIP-FOR with a number high or equal to the duration of the ad or omit this parameter, you have the old behavior.
joeyparrish
approved these changes
Oct 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #7466