Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add creating missing SQLite database files #400

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

DarkGhostHunter
Copy link

@DarkGhostHunter DarkGhostHunter commented Jul 11, 2024

This PR allows the container to start and create missing the SQLite databases set by the application.

It's part of the container AUTORUN_LARAVEL scripts. It runs before the migrations. Is opt-in by default, mostly because usually production apps run on non-SQLite but PR/preview/staging apps sometimes do spin SQLite for testing or pure convenience.

The way it works is through the AUTORUN_LARAVEL_TOUCH_SQLITE environment value, which by default is false:

  • When true, 1 or default, it will pick the default connection.
  • When used as default, telescope, custom, it will find the connection names, and create each database file.

This is done by checking if the driver is sqlite and the file doesn't exist. If it's not SQLite, it fails. If the database file already exists, doesn't do anything.

Note

Newer Laravel versions do create the SQLite database file when force migrating. Outside that command, it won't.

@jaydrogers
Copy link
Member

Thanks for the PR on this. I just ran into this issue myself.

Regarding your comment:

Newer Laravel versions do create the SQLite database file when force migrating. Otherwise, it won't.

Do you know what version this started happening in?

@DarkGhostHunter
Copy link
Author

I believe 9.x or 8.x, I'll have to see the blame.

@jaydrogers
Copy link
Member

Thanks!

If it goes back that far with Laravel, should we even merge this?

I was able to resolve my issue by having proper permissions on my Docker Volumes with Laravel 11. Once I had the correct permissions, the auomations worked perfectly and created my database.

@DarkGhostHunter
Copy link
Author

Thanks!

If it goes back that far with Laravel, should we even merge this?

I was able to resolve my issue by having proper permissions on my Docker Volumes with Laravel 11. Once I had the correct permissions, the auomations worked perfectly and created my database.

9.31 laravel/framework#44153

It doesn't go that far IMHO. In any case, I think older Laravel apps would benefit from this on staging and development, especially if you are on the path to upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants