This repository has been archived by the owner on Dec 9, 2024. It is now read-only.
Use the real Knative Service URL instead of assuming example.com #4
+24
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This plumbs through the Knative Service URLs returned from serverless-components/knative-serving#2 into the CLI. This change depends on that serverless-components/knative-serving one to get merged first and the version bumped in package.json to provide the new Knative Service URLs. This fixes serverless#3. It partially addresses serverless#2 as well, but the actual function invocation logic still tries the Istio IP if one is found. If not, it falls back to directly using the Knative Service URL given.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plumbs through the Knative Service URLs returned from
serverless-components/knative-serving#2 into
the CLI. This change depends on that
serverless-components/knative-serving one to get merged first and the
version bumped in package.json to provide the new Knative Service URLs.
This fixes #3.
It partially addresses #2 as well, but the actual function invocation
logic still tries the Istio IP if one is found. If not, it falls back
to directly using the Knative Service URL given.