Add some request headers to the log #215
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sungam3r
reviewed
Oct 22, 2020
sungam3r
reviewed
Oct 22, 2020
| static LogEventProperty GetRequestHeaders(HttpContext httpContext) | ||
| { | ||
| var values = httpContext.Request.Headers | ||
| .Where(x => allowedHeaders.Contains(x.Key.ToLowerInvariant())) |
There was a problem hiding this comment.
Maybe use case insensitive comparoson instead ToLower ?
Co-authored-by: Ivan Maximov <[email protected]>
|
Hi @SimonCropp! This would need to be an opt-in; currently the middleware adds only what's required in order to render its message template, since the bulk of request logs can quickly climb once more details are included. #207 is related; we might want to align them somewhat. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason it does a hard coded subset is i want to avoid writing security info that may be in other headers (eg cookies).