Update _element.py #228
Open
Update _element.py #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add is_element_exist、get_element_enabled、is_element_visible、is_page_contain_text、get_text_selected、get_name
update name->element.name
|
update name->element.name |
serhatbolsu
requested changes
Dec 27, 2022
| @@ -615,3 +615,66 @@ def _is_visible(self, locator): | |||
| return element.is_displayed() | |||
| return None | |||
|
|
|||
| def is_element_exist(self, locator): | |||
| """add Get that element with locator is existed. | |||
There was a problem hiding this comment.
remove the "add" in front of keyword documentation please
| return False | ||
|
|
||
| def get_text_selected(self, text, exact_match=False): | ||
| """add Get text with locator is selected. |
There was a problem hiding this comment.
can you explain what does this do exactly? what is is_selected()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add is_element_exist、get_element_enabled、is_element_visible、is_page_contain_text、get_text_selected、get_name