Remove magic from autocomplete #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbt365
approved these changes
Oct 21, 2024
8 tasks
GnomedDev
added a commit
that referenced
this pull request
Nov 13, 2024
GnomedDev
added a commit
that referenced
this pull request
Nov 13, 2024
GnomedDev
added a commit
that referenced
this pull request
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This demagics autocomplete, which currently does autoref-specialisation to duck type the return type of the autocomplete function.... all to collect into a vec and pass it normally into a
serenity::CreateAutocompleteResponse. This is way over the top and doesn't fit with our goal of merging poise into serenity.