Fallback Pipeline addition in core/v2 #16
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: manisha kumari <[email protected]>
Signed-off-by: manisha kumari <[email protected]>
Signed-off-by: manisha kumari <[email protected]>
Signed-off-by: manisha kumari <[email protected]>
Signed-off-by: manisha kumari <[email protected]>
Signed-off-by: manisha kumari <[email protected]>
Signed-off-by: manisha kumari <[email protected]>
Signed-off-by: manisha kumari <[email protected]>
fguimond
reviewed
Jul 23, 2024
| @@ -168,9 +168,13 @@ message CheckConfig { | |||
| // Pipelines are the pipelines this check will use to process its events. | |||
| repeated ResourceReference pipelines = 32 [ (gogoproto.jsontag) = "pipelines" ]; | |||
|
|
|||
| repeated MetricThreshold output_metric_thresholds = 33 [ (gogoproto.jsontag) = "output_metric_thresholds,omitempty", (gogoproto.moretags) = "yaml: \"output_metric_thresholds,omitempty\"" ]; | |||
There was a problem hiding this comment.
I believe we need to avoid changing field numbers since they're used for serialization/deserialization. We might end up with a scenario where the data was stored with field number 33 in etcd and read back with field number 34, effectively breaking serialization.
fguimond
reviewed
Jul 23, 2024
v2/check.proto
Outdated
| // MetricThresholds are a list of thresholds to apply to metrics in order to determine | ||
| // the check status. | ||
| repeated MetricThreshold output_metric_thresholds = 47 [ (gogoproto.jsontag) = "output_metric_thresholds,omitempty", (gogoproto.moretags) = "yaml: \"output_metric_thresholds,omitempty\"" ]; |
There was a problem hiding this comment.
Same comment about field numbers.
fguimond
reviewed
Jul 23, 2024
v2/check.proto
Outdated
| @@ -328,11 +332,14 @@ message Check { | |||
| // Pipelines are the pipelines this check will use to process its events. | |||
| repeated ResourceReference pipelines = 46 [ (gogoproto.jsontag) = "pipelines" ]; | |||
|
|
|||
| //fallback pieplines detials in order of execution | |||
| repeated ResourceReference fallback_pipeline = 47 [ (gogoproto.jsontag) = "fallback_pipeline" ,(gogoproto.moretags) = "yaml: \"fallback_pipeline,omitempty\"" ]; | |||
There was a problem hiding this comment.
If there can be more than one this field should be plural (fallback_pipelines).
fguimond
reviewed
Jul 23, 2024
v2/check.proto
Outdated
| @@ -328,11 +332,14 @@ message Check { | |||
| // Pipelines are the pipelines this check will use to process its events. | |||
| repeated ResourceReference pipelines = 46 [ (gogoproto.jsontag) = "pipelines" ]; | |||
|
|
|||
| //fallback pieplines detials in order of execution | |||
fguimond
reviewed
Jul 23, 2024
v2/secret.proto
Outdated
| @@ -1,7 +1,7 @@ | |||
| syntax = "proto3"; | |||
|
|
|||
| import "github.com/gogo/[email protected]/gogoproto/gogo.proto"; | |||
| import "github.com/sensu/core/v2/meta.proto"; | |||
| //import "github.com/sensu/core/v2/meta.proto"; | |||
There was a problem hiding this comment.
If not used it should be removed.
fguimond
reviewed
Jul 23, 2024
v2/types_gen.go
Outdated
| // this at the time of this writing. | ||
|
|
||
| // | ||
| //TODO: go build will build the latest version of the protoc-gen-gofast module |
There was a problem hiding this comment.
Nitpick: I think your editor might be removing the spaces after // in comments. We probably want the spaces for consistency.
fguimond
reviewed
Jul 23, 2024
v2/pipeline.proto
Outdated
| //FallbackPipelineListflow Pipelinelist = 2 [ (gogoproto.jsontag) = "pipelinelist", (gogoproto.moretags) = "yaml: \"pipelinelist\"" ]; | ||
| repeated ResourceReference pipelist =2 [ (gogoproto.jsontag) = "pipelinelist", (gogoproto.moretags) = "yaml: \"pipelinelist\"" ]; | ||
| } | ||
|
|
There was a problem hiding this comment.
Nitpick: no need for the extra empty lines.
fguimond
reviewed
Jul 23, 2024
v2/pipeline.proto
Outdated
|
|
||
| // FallbackpipelineList contains one or more pipeline list. | ||
| //FallbackPipelineListflow Pipelinelist = 2 [ (gogoproto.jsontag) = "pipelinelist", (gogoproto.moretags) = "yaml: \"pipelinelist\"" ]; | ||
| repeated ResourceReference pipelist =2 [ (gogoproto.jsontag) = "pipelinelist", (gogoproto.moretags) = "yaml: \"pipelinelist\"" ]; |
There was a problem hiding this comment.
Is it Pipelinelist or pipelist? I believe it should be PipelineList with camel-case.
Signed-off-by: manisha kumari <[email protected]>
Signed-off-by: manisha kumari <[email protected]>
Signed-off-by: manisha kumari <[email protected]>
Signed-off-by: manisha kumari <[email protected]>
Signed-off-by: manisha kumari <[email protected]>
Signed-off-by: manisha kumari <[email protected]>
Signed-off-by: manisha kumari <[email protected]>
|
@fguimond addressed all review points |
Signed-off-by: manisha kumari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to Fallback-pipeline execution task [https://github.com/sensu/sensu-enterprise-go/issues/1918]
Addition of FallbackPipeline Resource in core/v2 and related yaml structure