Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed dht library to adafruit-circuitpython-dht #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gmos
Copy link
Contributor

@gmos gmos commented Apr 22, 2020

PR to get Francesco's DHT library update...

@gmos
Copy link
Contributor Author

gmos commented Apr 22, 2020

Thanks Francesco, I'll give it a test. Glancing over it I saw one thing to change. self._sensor = sensor(pin) should be self._sensor = sensor(pin[0]) since the pins in AE are class AE_Pin members which are tuples with the actual BCM pin number at position 0.
As you don't have a DHT (right?) to test seems best I'll make it working here and add it to the baseline. ### you OK with that?

@Sprootsy
Copy link

No problem, take it.

@gmos
Copy link
Contributor Author

gmos commented Apr 29, 2020

I want to discuss this in our next meeting. The proposed DHT11 library is for Circuit Python. It requires a glue layer too, see https://learn.adafruit.com/circuitpython-on-raspberrypi-linux/installing-circuitpython-on-raspberry-pi
Since Adafruit has announced to stop support for all their Python libraries, except the "circuitpython" series, we may bump into this more often in future. So that would mean we will need to investigate the use of the glue layer.
Let's discuss next time (@MichielBbal )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants